Skip to content

backport: default system vm template update implementation #12935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shwstppr wants to merge 1 commit into
base: 4.20
Choose a base branch
from
+15 −5
Draft

backport: default system vm template update implementation #12935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion engine/schema/src/main/java/com/cloud/upgrade/dao/DbUpgradeSystemVmTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,23 @@

package com.cloud.upgrade.dao;

import com.cloud.upgrade.SystemVmTemplateRegistration;
import com.cloud.utils.exception.CloudRuntimeException;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.sql.Connection;

public interface DbUpgradeSystemVmTemplate {

void updateSystemVmTemplates(Connection conn);
default void updateSystemVmTemplates(Connection conn) {
Logger logger = LogManager.getLogger(getClass());
logger.debug("Updating System Vm template IDs");
try {
SystemVmTemplateRegistration systemVmTemplateRegistration = new SystemVmTemplateRegistration("");
systemVmTemplateRegistration.updateSystemVmTemplates(conn);
} catch (Exception e) {
throw new CloudRuntimeException("Failed to find / register SystemVM template(s)");
}
}
}
4 changes: 0 additions & 4 deletions engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42020to42030.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,4 @@ public void performDataMigration(Connection conn) {
public InputStream[] getCleanupScripts() {
return null;
}

@Override
public void updateSystemVmTemplates(Connection conn) {
}
}
Loading