Skip to content

backport: default system vm template update implementation#12935

Draft
shwstppr wants to merge 1 commit intoapache:4.20from
shwstppr:backport-420-sysvmup
Draft

backport: default system vm template update implementation#12935
shwstppr wants to merge 1 commit intoapache:4.20from
shwstppr:backport-420-sysvmup

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

Description

Fixes #12934

Backported from 889fc62

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#12934

Backported from 889fc62

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (c19630f) to head (8c84ad4).
⚠️ Report is 4 commits behind head on 4.20.

Files with missing lines Patch % Lines
...m/cloud/upgrade/dao/DbUpgradeSystemVmTemplate.java 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #12935      +/-   ##
============================================
+ Coverage     16.25%   16.26%   +0.01%     
- Complexity    13415    13434      +19     
============================================
  Files          5664     5665       +1     
  Lines        500465   500530      +65     
  Branches      60780    60787       +7     
============================================
+ Hits          81338    81411      +73     
+ Misses       410031   410028       -3     
+ Partials       9096     9091       -5     
Flag Coverage Δ
uitests 4.15% <ø> (ø)
unittests 17.11% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland DaanHoogland added this to the 4.20.3 milestone Mar 31, 2026
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Copy link
Copy Markdown
Contributor

@sudo87 sudo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants