fix(injectable): don't default providedIn to 'root' when not specified#194
Merged
Brooooooklyn merged 1 commit intovoidzero-dev:mainfrom Mar 30, 2026
Conversation
@Injectable() and @Injectable({}) were incorrectly defaulting providedIn to 'root'. Angular's actual behavior is to omit providedIn entirely when it's not explicitly specified, as confirmed by the official compliance tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Injectable()and@Injectable({})no longer incorrectly defaultprovidedInto'root'providedInis not explicitly specified, it is now omitted entirely, matching Angular's actual compiler behaviorinjectable_factory.tsexpects noprovidedInfield in output)Test plan
decorator.rsto assertprovided_in.is_none()for bare@Injectable()and@Injectable({})transform.rsto verifyprovidedInis absent in compiled output