Split out detector types into separate proto file in order to narrow CODEOWNERS scope#4847
Open
casey-tran wants to merge 2 commits intomainfrom
Open
Split out detector types into separate proto file in order to narrow CODEOWNERS scope#4847casey-tran wants to merge 2 commits intomainfrom
casey-tran wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We want to move the detector types out of the Scanning team purview. So I split off detector types into its own proto file (so that file
detector_type.protocan be owned by the Integrations team), regenerated the pb files with"make protos", and made the detector files use the new generateddetector_type.pb.go.Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Broad mechanical refactor across many detectors and config parsing to use the new
detector_typepb.DetectorTypeenum, which could cause build/runtime mismatches if any call sites or generated protos were missed. No behavioral changes are intended beyond type/ownership wiring.Overview
Moves the
DetectorTypeenum into a newproto/detector_type.proto(with regenerated Go bindings underpkg/pb/detector_typepb) and updates config parsing (pkg/config/detectors*) plus detector implementations/tests to referencedetector_typepb.DetectorTypeinstead ofdetectorspb.DetectorType.Updates
CODEOWNERSsoproto/detector_type.protois owned by Integrations, narrowing review scope for detector-type changes while keeping the rest ofproto/shared.Written by Cursor Bugbot for commit 7f8da0a. This will update automatically on new commits. Configure here.