Skip to content

Split out detector types into separate proto file in order to narrow CODEOWNERS scope#4847

Open
casey-tran wants to merge 2 commits intomainfrom
take-detectors-out-of-scanning-team-purview
Open

Split out detector types into separate proto file in order to narrow CODEOWNERS scope#4847
casey-tran wants to merge 2 commits intomainfrom
take-detectors-out-of-scanning-team-purview

Conversation

@casey-tran
Copy link
Copy Markdown
Contributor

@casey-tran casey-tran commented Mar 27, 2026

Description:

We want to move the detector types out of the Scanning team purview. So I split off detector types into its own proto file (so that file detector_type.proto can be owned by the Integrations team), regenerated the pb files with "make protos", and made the detector files use the new generated detector_type.pb.go.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Note

Medium Risk
Broad mechanical refactor across many detectors and config parsing to use the new detector_typepb.DetectorType enum, which could cause build/runtime mismatches if any call sites or generated protos were missed. No behavioral changes are intended beyond type/ownership wiring.

Overview
Moves the DetectorType enum into a new proto/detector_type.proto (with regenerated Go bindings under pkg/pb/detector_typepb) and updates config parsing (pkg/config/detectors*) plus detector implementations/tests to reference detector_typepb.DetectorType instead of detectorspb.DetectorType.

Updates CODEOWNERS so proto/detector_type.proto is owned by Integrations, narrowing review scope for detector-type changes while keeping the rest of proto/ shared.

Written by Cursor Bugbot for commit 7f8da0a. This will update automatically on new commits. Configure here.

@casey-tran casey-tran requested a review from a team March 27, 2026 23:38
@casey-tran casey-tran requested review from a team as code owners March 27, 2026 23:38
@casey-tran casey-tran marked this pull request as draft March 27, 2026 23:56
@casey-tran casey-tran marked this pull request as ready for review March 28, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant