Skip to content

test: cover event shorthand normalization gaps#68

Draft
overtrue wants to merge 1 commit intomainfrom
codex/event-shorthand-test-gaps
Draft

test: cover event shorthand normalization gaps#68
overtrue wants to merge 1 commit intomainfrom
codex/event-shorthand-test-gaps

Conversation

@overtrue
Copy link
Copy Markdown
Contributor

Summary

This change adds focused regression coverage for the event shorthand normalization fix merged on main.

Users were affected when shorthand event names such as put, get, delete, replica, and ilm needed to normalize to the persisted S3 notification event strings. The recent fix corrected the implementation, but there were still untested branches around how those normalized values interact with already-canonical inputs.

The root cause of the remaining test gap was that existing coverage only verified shorthand mapping in isolation. It did not verify that shorthand and canonical values collapse to the same persisted event after normalization, and it did not exercise the passthrough branch for already-canonical or custom event names.

This PR keeps scope tight by adding two unit tests in the event command:

  • one verifies shorthand and canonical event names deduplicate after normalization
  • one verifies non-shorthand values are preserved unchanged

Validation

I ran the required repository checks after the test additions:

  • cargo fmt --all --check
  • cargo clippy --workspace -- -D warnings
  • cargo test --workspace

@overtrue overtrue changed the title [codex] cover event shorthand normalization gaps test: cover event shorthand normalization gaps Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant