Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #97
Hightlightthickness is 0 means the Text widget will not show the highlight border and I agree this, because the border looks ugly.
And here is a screenshot that shows the difference between borderwidth=2 and the normal borderwidth, there are 1px black frame in the left and 2px grey frame in the bottom, so I disagree the second.
And the relief, here is the screenshot (test with borderwidth=2):
I think normal relief is better than the solid, so I think they can set the solid by themself.
So we just need set the
highlightthickness=0as default.(Of course this is just my option, maybe we can ask Akuli for options.)