fix: snapshot release fails#3257
Conversation
on first look it seems because of missing relative path Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses a snapshot/release build failure by making Maven parent resolution explicit for several modules and updates the observability docs to reflect the namespace tag behavior for events.received.
Changes:
- Add
<relativePath>../pom.xml</relativePath>to the<parent>section of several module POMs. - Update the MicrometerMetricsV2 documentation for
events.receivedtags/description.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test-index-processor/pom.xml | Explicitly sets Maven parent relativePath to root pom. |
| sample-operators/pom.xml | Explicitly sets Maven parent relativePath to root pom. |
| migration/pom.xml | Explicitly sets Maven parent relativePath to root pom. |
| micrometer-support/pom.xml | Explicitly sets Maven parent relativePath to root pom. |
| bootstrapper-maven-plugin/pom.xml | Explicitly sets Maven parent relativePath to root pom. |
| docs/content/en/docs/documentation/observability.md | Documents events.received namespace tag as optional (with withNamespaceAsTag()) and updates description. |
|
Any idea of why that change is needed? |
Not entirely sure why this popped up now, but also it is an issue here: Pls take a look, maybe you will have a better idea. (I did not spend too much time on it to analyizing) |
|
But this is anyway a good practice |
The thing I don't understand is that this should be the default behavior, i.e. if you don't specify a parent path, then maven will look at the containing directory and if that directory contains a pom file with the appropriate GAV then it's considered as the parent POM. So specifying that the relative parent path is |
|
Ahh sorry my bad: |
on first look it seems because of missing relative path
Signed-off-by: Attila Mészáros a_meszaros@apple.com