Use symbolize_names: true in JSON.parse calls#279
Open
koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Use symbolize_names: true in JSON.parse calls#279koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
symbolize_names: true in JSON.parse calls#279koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Replace custom `deep_transform_keys` in `Tool::Schema` and string key access in `StreamableHTTPTransport` with the `symbolize_names: true` option of `JSON.parse`. This aligns `StreamableHTTPTransport` with `StdioTransport`, which already uses `symbolize_names: true`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Replace custom
deep_transform_keysinTool::Schemaand string key access inStreamableHTTPTransportwith thesymbolize_names: trueoption ofJSON.parse.This aligns
StreamableHTTPTransportwithStdioTransport, which already usessymbolize_names: true.How Has This Been Tested?
This is a refactoring that preserves the existing tests.
Breaking Changes
None.
Types of changes
Checklist