[Server] Fix to make Symfony Finder component optional#267
[Server] Fix to make Symfony Finder component optional#267bigdevlarry wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
68bd923 to
bc19684
Compare
dd9bfef to
6e8e705
Compare
|
Can you also add a change to https://github.com/modelcontextprotocol/php-sdk/blob/main/src/Server/Builder.php#L526 ? Avoid calling the |
|
@soyuka, this means the discoverer will never be called if there's no finder, and we won't be able to raise the exception to prompt the installation of the finder itself. By your suggestion, adding a null check silences the error in the logs, and the program continues as expected. Is this the ideal behaviour, or should we halt the program with the exception as we have it, so users go back to install? Let me know what you think as well @chr-hertel |
|
Mhh from this PR I thought you wanted to move the If we don't want to move this requirement, then I'm not sure I understand how this code path is going to happen as its required in our dependencies. |
5e7405e to
7438ab1
Compare
and yes, the code should work unless you want to use the built-in discoverer. if a user calls We should add this as BC break to changelog tho, since users would need to install |
|
@soyuka this is now what you've been thinking, right? |
903b991 to
98991a8
Compare
0c437fa to
febba83
Compare
Motivation and Context
The changes make the Symfony Finder component optional, as referenced in issue #263
How Has This Been Tested?
Yes
Breaking Changes
Not a breaking change
Types of changes
Checklist
Additional context