Skip to content

TPT-4368: Update integration tests due to deprecated "vpcs" for NB create#676

Open
mawilk90 wants to merge 2 commits intolinode:proj/nb-front-end-ip-in-vpcfrom
mawilk90:feature/TPT-4368-sdks-update-integration-tests-due-to-deprecated-vpcs-for-nb-create
Open

TPT-4368: Update integration tests due to deprecated "vpcs" for NB create#676
mawilk90 wants to merge 2 commits intolinode:proj/nb-front-end-ip-in-vpcfrom
mawilk90:feature/TPT-4368-sdks-update-integration-tests-due-to-deprecated-vpcs-for-nb-create

Conversation

@mawilk90
Copy link
Copy Markdown
Contributor

@mawilk90 mawilk90 commented Mar 31, 2026

📝 Description

Changes related to the fact that "vpcs" attribute is deprecated (but still valid) in favor of "backend_vpcs" in POST /nodebalancers

✔️ How to Test

make test-int TEST_SUITE=nodebalancer TEST_ARGS="-k test_nb_with"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates NodeBalancer integration tests to align with the API change where the vpcs request attribute for POST /nodebalancers is deprecated in favor of backend_vpcs.

Changes:

  • Replace vpcs= with backend_vpcs= in NodeBalancer create calls for backend-only VPC attachment.
  • Replace vpcs= with backend_vpcs= in NodeBalancer create calls when backend and frontend VPCs are configured separately.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dawiddzhafarov
Copy link
Copy Markdown
Contributor

What do you think of having a separate test case that still uses the deprecated "vpcs" argument and having a comment explaining that this test verifies it still works until its supported? Then, after it's not, we could remove it?

@mawilk90
Copy link
Copy Markdown
Contributor Author

@dawiddzhafarov

What do you think of having a separate test case that still uses the deprecated "vpcs" argument and having a comment explaining that this test verifies it still works until its supported? Then, after it's not, we could remove it?

Yes, I will add something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants