Skip to content

docs: clarify forked pull request token wording#43508

Merged
Sharra-writes merged 4 commits intogithub:mainfrom
hiromieguchi802-lab:docs/clarify-pr-target-token-permissions
Mar 30, 2026
Merged

docs: clarify forked pull request token wording#43508
Sharra-writes merged 4 commits intogithub:mainfrom
hiromieguchi802-lab:docs/clarify-pr-target-token-permissions

Conversation

@hiromieguchi802-lab
Copy link
Copy Markdown
Contributor

Summary

  • clarify that the write-token downgrade applies to forked pull request events except pull_request_target
  • avoid implying that pull_request_target is subject to the same read-only adjustment

Fixes #32398.

Testing

  • ran npm run lint-content -- --precommit --paths content/actions/reference/workflows-and-actions/workflow-syntax.md

@welcome
Copy link
Copy Markdown

welcome bot commented Mar 24, 2026

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
actions/reference/workflows-and-actions/workflow-syntax.md fpt
ghec
ghes@ 3.20 3.19 3.18 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.20 3.19 3.18 3.17 3.16 3.15 3.14

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@Sharra-writes
Copy link
Copy Markdown
Contributor

@hiromieguchi802-lab This looks right to me based on the issue, so I'll give it approval. We are (still) in a deploy freeze, though, so I can't merge yet. Not sure when it's going to end, or I would give you a timeframe.

@Sharra-writes Sharra-writes added ready to merge This pull request is ready to merge and removed triage Do not begin working on this issue until triaged by the team labels Mar 25, 2026
@hiromieguchi802-lab
Copy link
Copy Markdown
Contributor Author

Thanks again for the approval and for the note about the deploy freeze.

No rush from my side. If it helps once the freeze lifts, I can rebase the branch to bring it back up to date with \main\.

Copy link
Copy Markdown

@saqlianmalik91-dot saqlianmalik91-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @****

@Sharra-writes Sharra-writes removed the ready to merge This pull request is ready to merge label Mar 30, 2026
@Sharra-writes Sharra-writes added this pull request to the merge queue Mar 30, 2026
Merged via the queue into github:main with commit 9de2b76 Mar 30, 2026
41 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify How the permissions are calculated for a workflow job

3 participants