feat(langchain): Record run_name in on_tool_start#5925
Open
alexander-alderman-webb wants to merge 4 commits intowebb/langchain/pipeline-namefrom
Open
feat(langchain): Record run_name in on_tool_start#5925alexander-alderman-webb wants to merge 4 commits intowebb/langchain/pipeline-namefrom
run_name in on_tool_start#5925alexander-alderman-webb wants to merge 4 commits intowebb/langchain/pipeline-namefrom
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Langchain
Other
Bug Fixes 🐛Ci
Openai
Other
Documentation 📚
Internal Changes 🔧Ai
Langchain
Openai
Other
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 7.78s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 14672 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| ) | ||
|
|
||
| run_name = kwargs.get("name") | ||
| if run_name: |
There was a problem hiding this comment.
Inconsistent None check for run_name across callbacks
Low Severity
The run_name guard in on_tool_start uses a truthy check (if run_name:) whereas the equivalent check in on_chat_model_start uses if run_name is not None:. This means an empty-string run_name would be recorded as GEN_AI_PIPELINE_NAME for chat model spans but silently dropped for tool spans, creating inconsistent behavior across callback methods for the same field.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)