Clarify admin-settings.json workaround version scope#24581
Open
lacatoire wants to merge 1 commit intodocker:mainfrom
Open
Clarify admin-settings.json workaround version scope#24581lacatoire wants to merge 1 commit intodocker:mainfrom
lacatoire wants to merge 1 commit intodocker:mainfrom
Conversation
Rephrase the version-specific workaround to clearly state which versions require the manual deletion step and that version 4.60+ no longer needs it. Fixes docker#24545
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The note about manually deleting the
admin-settings.jsonfile uses time-relative language ("with Docker Desktop version 4.59 and earlier") without explaining what changed in later versions.This rephrases the note to clearly state:
Fixes #24545