Cix-ACPI: Initial work for support on vendor 2025Q4 & current/edge#9395
Cix-ACPI: Initial work for support on vendor 2025Q4 & current/edge#9395HeyMeco wants to merge 14 commits intoarmbian:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds Cix-ACPI board metadata and runtime hooks, introduces a new cix-p1 family with branch-scoped kernel/GRUB and firmware hooks, and adds three full kernel defconfigs (vendor/current/edge). Also adds a post-family tweak to conditionally install mesa-vulkan-drivers from Debian Trixie backports. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Builder as Builder (host)
participant BoardHook as post_family_tweaks (board)
participant Chroot as chroot_sdcard
participant Debian as Debian Trixie Backports Repo
rect rgba(100,150,240,0.5)
Builder->>BoardHook: invoke post_family_tweaks__cix_acpi_mesa_backports()
end
BoardHook->>Builder: display "Installing mesa-vulkan-drivers from backports"
BoardHook->>Chroot: chroot_sdcard_apt_get install -t trixie-backports mesa-vulkan-drivers
Chroot->>Debian: request mesa-vulkan-drivers (trixie-backports)
Debian-->>Chroot: package archive response
Chroot-->>BoardHook: install result
BoardHook->>Builder: display success or warning (if not Debian Trixie)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size/large
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
Needs review
|
nice work! |
This comment was marked as outdated.
This comment was marked as outdated.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@config/kernel/linux-cix-p1-vendor.config`:
- Around line 1191-1192: The vendor kernel config enables KASAN which causes
runtime overhead; remove or disable CONFIG_KASAN and CONFIG_KASAN_HW_TAGS for
release builds by setting CONFIG_KASAN to n (or removing the CONFIG_KASAN line)
and CONFIG_KASAN_HW_TAGS to n (or removing that line) in the vendor config so
KASAN is not compiled into the kernel; ensure any build profiles for development
still re-enable these options separately if needed.
🧹 Nitpick comments (3)
config/kernel/linux-cix-p1-vendor.config (2)
763-765: Multiple debug/test options left enabled — likely source of verbose dmesg.The PR notes "overly verbose dmesg output (possible trace-related)" as a known issue. Several debug and test configs are enabled that would contribute to this:
- Line 70:
CONFIG_PM_DEBUG=y- Line 395:
CONFIG_CIX_HF_TEST_CASE=y- Lines 763–765:
CONFIG_SND_DEBUG=y,CONFIG_SND_DEBUG_VERBOSE=y,CONFIG_SND_PCM_XRUN_DEBUG=y- Line 964:
CONFIG_DMATEST=y- Line 1000:
CONFIG_CIX_CLK_DEBUG=yConsider disabling these for the release config. At minimum,
SND_DEBUG_VERBOSEandCIX_CLK_DEBUGare likely high-volume dmesg contributors. Note that since the PR also mentions ALSA audio configuration is missing, disabling the sound debug options should have no negative impact on functionality.Also applies to: 1000-1000, 395-395, 964-964, 70-70
49-61: Broad architecture enablement for a CIX-specific vendor kernel.Lines 49–60 enable many unrelated ARM64 SoC families (Actions, Apple, Broadcom, Keembay, NXP, Nuvoton, Realtek, Intel SoCFPGA, STM32, etc.) alongside
CONFIG_ARCH_CIX=y. For a vendor-specific kernel targeting CIX boards only, these add unnecessary code to the kernel image and increase build time. Consider trimming to justARCH_CIX(and any actual dependencies) unless there's a specific reason to keep them.config/boards/cix-acpi.conf (1)
15-15: Trixie-specific guard is appropriate but will need updating for future releases.The
trixiecheck is correct for the current target. As a minor note for future maintenance: when Debian moves beyond trixie, this condition and the backports source will need to be revisited. This is acceptable for initial support work.
This comment was marked as outdated.
This comment was marked as outdated.
HeyMeco
changed the title
- Remove unneeded drivers that cause firmware lookup issues. - Make CONFIG_BT=Y (so it includes BLE by default)
|
|
||
| # Install Sky1 firmware package | ||
| display_alert "Installing Sky1 firmware" "sky1-firmware" "info" | ||
| chroot_sdcard_apt_get_install sky1-firmware |
There was a problem hiding this comment.
We can consider pushing kernel drivers to armbian's firmware repo and package alsa config file to armbian's bsp package.
There was a problem hiding this comment.
Could you do the armbian-firmware part? I was not able to source the firmware files besides the binaries from the sky1-firmware repo (where do they come from?)
There was a problem hiding this comment.
mali firmware is already merged upstream. vpu and dsp firmware are from cix sdk, maybe we should set subdir like /lib/firmware/cix/vpu instead of /lib/firmware.
There was a problem hiding this comment.
100%, not sure how to link it though. Probably patch the kernel driver
There was a problem hiding this comment.
Decide for one option and lets merge this.
amazingfate
left a comment
amazingfate
left a comment
There was a problem hiding this comment.
sky1-firmware has kernel firmware for mali and vpu/dsp, and alsa config file. They can all get intergated into armbian's framework, no need to add a third party repo and install a third party package.
|
|
||
| # Install Sky1 firmware package | ||
| display_alert "Installing Sky1 firmware" "sky1-firmware" "info" | ||
| chroot_sdcard_apt_get_install sky1-firmware |
There was a problem hiding this comment.
Decide for one option and lets merge this.
|
|
||
| # Only install on Debian Trixie | ||
| if [[ "${RELEASE}" == "trixie" && "${DISTRIBUTION}" == "Debian" ]]; then | ||
| # Update mesa from backports |
There was a problem hiding this comment.
Why don't we deal with mesa in the mesa extension?
|
Hi |
| chroot_sdcard_apt_get_install sky1-firmware | ||
|
|
||
| display_alert "Installing Mediatek firmware" "sky1-firmware" "info" | ||
| chroot_sdcard_apt_get_install firmware-mediatek # Install Mediatek firmware for WiFi and Bluetooth (used on MS-R1) |
There was a problem hiding this comment.
mediatek need to be installed from different source -
[🐳|🌱] Installing Mediatek firmware [ sky1-firmware ]
[🐳|🔨] E: Unable to locate package firmware-mediatek
[🐳|💥] Error 1 occurred in main shell [ at /armbian/lib/functions/logging/runners.sh:15
chroot_sdcard_apt_get_install() --> lib/functions/logging/runners.sh:15
family_tweaks() --> config/sources/families/cix-p1.conf:110
install_distribution_agnostic() --> lib/functions/rootfs/distro-agnostic.sh:458
do_with_logging() --> lib/functions/logging/section-logging.sh:81
build_rootfs_and_image() --> lib/functions/main/rootfs-image.sh:31
full_build_packages_rootfs_and_image() --> lib/functions/main/default-build.sh:36
do_with_default_build() --> lib/functions/main/default-build.sh:42
cli_standard_build_run() --> lib/functions/cli/cli-build.sh:25
armbian_cli_run_command() --> lib/functions/cli/utils-cli.sh:136
cli_entrypoint() --> lib/functions/cli/entrypoint.sh:208
main() --> compile.sh:50
]
[🐳|💥] Cleaning up [ please wait for cleanups to finish ]
| BOARD_NAME="Cix-ACPI" | ||
| BOARD_VENDOR="cixtech" | ||
| BOARDFAMILY="cix-p1" | ||
| KERNEL_TARGET="current, edge, vendor" |
|
Great job! Looking forward to seeing it merged |
|
Also works for 7.0-rc1 btw. |
Will revise. How do those issues show? |
The most obvious is error messages when motd pops up (requires first boot user setup completed). |
I noticed the same thing |
|
Looking forward to this board addition to Armbian! Since Linux is allergic to multiple GPUs in one system, hopefully there will be an easy off-switch for the Immortalis iGPU (at least for the Radxa Orion O6). |
|
Hi everyone, Exciting progress on the CIX front! It looks like CIX has just updated their kernel patchsets for 6.18 and 7.0: Mainline kernel patches: NPU driver (7.0 kernel): VPU driver (7.0 kernel): Really nice to see upstream work moving forward. Hopefully this helps the Armbian integration effort! Cheers |
|
Has anyone successfully used |
|
For SD Card idk but for nvme I would guess it has something to do with how we don’t do GPT with armbian-install+ move the boot partition on this family |
install os from armbian build tool stable -> you don't have video -> install mainline kernel 7 and you get video and all hardware work -> update all packages -> armbian-config and move os and boot to nvme -> done! |
You need to go into the BIOS and manually specify the location of the EFI boot file; it doesn't seem to detect it automatically. |
and that is because we don’t do GPT partitioning and don’t keep the boot partitions efi guid (C12A7328-F81F-11D2-BA4B-00A0C93EC93B). See https://wiki.archlinux.org/title/EFI_system_partition#GPT_partitioned_disks It is something we are already aware of here: #9454 |
|
just |
If you don’t keep the storage medium connected from where you installed that is one way currently to keep partition uuid's correct but you have to remove the base storage medium as it will lead to conflict otherwise. |
|
I did not dd directly from the microsd but from an actual image which I moved to the sdcard which I booted from beforehand. |
10 participants
Description
Now that the Cix 2025Q4 Vendor kernel is available I started working on basic support.
+
Current & Edge based on https://github.com/Sky1-Linux latest ACPI additions.
Branch: Current & Edge
What works now (tested on Debian Trixie):
What is missing:
armchina_npudisabled due to kernel crash on bootRelated sources:
Branch: Vendor
What works now (tested on Debian Trixie):
What is missing:
What makes me unhappy:
Related sources:
Boards covered by this PR:
This is a follow up on #8363
Checklist:
Please delete options that are not relevant.