Skip to content

[CI] Add pre-commit hook to stop ZIP files being committed#12930

Open
jbampton wants to merge 1 commit intoapache:mainfrom
jbampton:add-zip-pre-commit-hook
Open

[CI] Add pre-commit hook to stop ZIP files being committed#12930
jbampton wants to merge 1 commit intoapache:mainfrom
jbampton:add-zip-pre-commit-hook

Conversation

@jbampton
Copy link
Copy Markdown
Member

Zip files are hard to track and have security implications

https://pre-commit.com/#repos-repo

https://pre-commit.com/#repository-local-hooks

https://pre-commit.com/#fail

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran pre-commit run --all-files

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.01%. Comparing base (7eea9ed) to head (90fc4d0).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12930      +/-   ##
============================================
- Coverage     18.02%   18.01%   -0.01%     
+ Complexity    16464    16463       -1     
============================================
  Files          5973     5973              
  Lines        537466   537466              
  Branches      65991    65991              
============================================
- Hits          96853    96833      -20     
- Misses       429690   429712      +22     
+ Partials      10923    10921       -2     
Flag Coverage Δ
uitests 3.52% <ø> (ø)
unittests 19.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbampton
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants