CLVM enhancements and fixes by Pearl1594 · Pull Request #12617 · apache/cloudstack

Pearl1594 · 2026-02-09T19:47:40Z

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-02-09T20:01:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.68%. Comparing base (d3e1976) to head (df61d6f).
⚠️ Report is 15 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (d3e1976) and HEAD (df61d6f). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (d3e1976) HEAD (df61d6f)

unittests 1 0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #12617       +/-   ##
=============================================
- Coverage     17.90%    3.68%   -14.23%     
=============================================
  Files          5938      454     -5484     
  Lines        532864    38798   -494066     
  Branches      65192     7151    -58041     
=============================================
- Hits          95392     1428    -93964     
+ Misses       426793    37183   -389610     
+ Partials      10679      187    -10492

Flag	Coverage Δ
uitests	`3.67% <ø> (+<0.01%)`	⬆️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…of running vm

Pearl1594 · 2026-02-11T19:43:29Z

@blueorangutan package

blueorangutan · 2026-02-11T19:44:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-11T20:28:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16801

weizhouapache · 2026-02-17T15:02:13Z

...apshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java

        UserVmVO vm = userVmDao.findById(vmId);
        String cantHandleLog = String.format("Default VM snapshot cannot handle VM snapshot for [%s]", vm);
+
+        if (isRunningVMVolumeOnCLVMStorage(vm, cantHandleLog)) {


@Pearl1594
what's the image format on CLVM ? RAW or QCOW2 ?

RAW @weizhouapache

codecov · 2026-02-17T15:24:41Z

Codecov Report

❌ Patch coverage is 41.99706% with 1185 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.12%. Comparing base (1bff543) to head (381dc67).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
.../hypervisor/kvm/storage/LibvirtStorageAdaptor.java	37.08%	422 Missing and 14 partials ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	44.71%	131 Missing and 5 partials ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java	21.73%	70 Missing and 2 partials ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	31.25%	62 Missing and 4 partials ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java	54.92%	58 Missing and 6 partials ⚠️
...resource/wrapper/LibvirtMigrateCommandWrapper.java	13.23%	52 Missing and 7 partials ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	16.98%	43 Missing and 1 partial ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java	28.57%	35 Missing ⚠️
...rce/wrapper/LibvirtPreMigrationCommandWrapper.java	7.40%	25 Missing ⚠️
...tack/storage/endpoint/DefaultEndPointSelector.java	71.23%	6 Missing and 15 partials ⚠️
... and 28 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12617      +/-   ##
============================================
+ Coverage     18.02%   18.12%   +0.10%     
- Complexity    16460    16656     +196     
============================================
  Files          5968     5976       +8     
  Lines        537213   539165    +1952     
  Branches      65975    66286     +311     
============================================
+ Hits          96825    97736     +911     
- Misses       429469   430429     +960     
- Partials      10919    11000      +81

Flag	Coverage Δ
uitests	`3.53% <ø> (-0.01%)`	⬇️
unittests	`19.29% <41.99%> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pearl1594 · 2026-02-18T16:33:12Z

@blueorangutan package

blueorangutan · 2026-02-18T16:40:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T17:32:01Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16875

Pearl1594 · 2026-02-18T20:23:11Z

@blueorangutan package

blueorangutan · 2026-02-18T20:24:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T21:16:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16877

…ached volumes

…ure, add unit tests

github-actions · 2026-03-26T20:00:54Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…-enhancements

…en migrating a vol with incremental snap

…as CLVM/CLVM-NG volumes

sonarqubecloud · 2026-03-31T16:29:47Z

Quality Gate failed

Failed conditions
1 Security Hotspot
29.4% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

…-enhancements

boring-cyborg bot added component:kvm component:storage labels Feb 9, 2026

CLVM enhancements and fixes

9e03f4b

Pearl1594 force-pushed the clvm-enhancements branch from 5fc1f12 to 9e03f4b Compare February 9, 2026 21:39

Pearl1594 added 2 commits February 10, 2026 19:48

add support for proper cleanup of snapshots and prevent vol snapshot …

96edadc

…of running vm

remove snap vol restriction for sunning vms

f9d8062

harikrishna-patnala added this to the 4.23.0 milestone Feb 17, 2026

weizhouapache reviewed Feb 17, 2026

View reviewed changes

Pearl1594 force-pushed the clvm-enhancements branch from a08e7a5 to df61d6f Compare February 17, 2026 15:04

refactor clvm code

43e9384

Pearl1594 force-pushed the clvm-enhancements branch from df61d6f to 43e9384 Compare February 17, 2026 15:16

boring-cyborg bot added component:api component:compute component:orchestration labels Feb 17, 2026

add support for live migration

c9dd7ed

Pearl1594 force-pushed the clvm-enhancements branch from 3f900e8 to c9dd7ed Compare February 17, 2026 22:54

add support for migrating lvm lock

4984ee5

Pearl1594 added 2 commits February 19, 2026 15:42

clvm deletion called explicitly

190b201

made necessary changes to allow migration of lock and deletion of det…

8a7e48a

…ached volumes

Pearl1594 added 3 commits March 25, 2026 17:44

Add support for incremental volume snapshots for clvm_ng

22c4934

refactor

8ed2a3a

prevent snapshot backup for incremental clvm_ng snaps, fix build fail…

70583a4

…ure, add unit tests

github-actions bot added the status:has-conflicts label Mar 26, 2026

Merge branch 'main' of https://github.com/apache/cloudstack into clvm…

237f074

…-enhancements

github-actions bot removed the status:has-conflicts label Mar 26, 2026

Pearl1594 added 3 commits March 27, 2026 14:08

fix lockhost on creation of volumes from snap and fix bitmap issue wh…

058007e

…en migrating a vol with incremental snap

add tests

0fcf12c

fix build failure, add tests

0afa603

Pearl1594 force-pushed the clvm-enhancements branch from 6ea9026 to f8ca597 Compare March 27, 2026 19:34

Pearl1594 closed this Mar 27, 2026

Pearl1594 reopened this Mar 27, 2026

Pearl1594 force-pushed the clvm-enhancements branch from f8ca597 to 8c189f9 Compare March 27, 2026 20:52

fix EOF and trailing spaces

2f0fc97

Pearl1594 force-pushed the clvm-enhancements branch from 8c189f9 to 2f0fc97 Compare March 27, 2026 20:57

remove failing test - fails on CI but passes locally

a923bdb

Pearl1594 force-pushed the clvm-enhancements branch 2 times, most recently from ac9a2e0 to d95e54b Compare March 30, 2026 15:55

add tests

93782bb

Pearl1594 force-pushed the clvm-enhancements branch from d95e54b to 93782bb Compare March 30, 2026 16:00

Pearl1594 added 2 commits March 30, 2026 15:15

restrict pre and post migration commands to only kvm hosts where vm h…

f84a507

…as CLVM/CLVM-NG volumes

add more tests

e45a43d

Pearl1594 force-pushed the clvm-enhancements branch 3 times, most recently from 2b2c45c to 0ebb4f9 Compare March 31, 2026 15:27

add more tests

381dc67

Pearl1594 force-pushed the clvm-enhancements branch from 0ebb4f9 to 381dc67 Compare March 31, 2026 16:50

Merge branch 'main' of https://github.com/apache/cloudstack into clvm…

6da3287

…-enhancements

Conversation

Pearl1594 commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

weizhouapache Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Pearl1594 Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

sonarqubecloud bot commented Mar 31, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Pearl1594 commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 17, 2026 •

edited

Loading