Skip to content

fix: remove Suspense from hero splash logo #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franklinjavier wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: remove Suspense from hero splash logo #786

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2b760a
fix: remove Suspense wrapper from hero splash logo to prevent CLS
franklinjavier Mar 26, 2026
e06362b
fix: use single splash image, remove hidden dark variant
franklinjavier Mar 26, 2026
cc6f863
fix: restore dark-mode splash with lazy loading
franklinjavier Mar 26, 2026
c35c8f4
fix: restore BrandContextMenu as direct import (no lazy/Suspense)
franklinjavier Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 19 additions & 55 deletions src/routes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ import LibraryCard from '~/components/LibraryCard'
import { FeaturedShowcases } from '~/components/ShowcaseSection'
import { Button } from '~/ui'

const LazyBrandContextMenu = React.lazy(() =>
import('~/components/BrandContextMenu').then((m) => ({
default: m.BrandContextMenu,
})),
)

export const textColors = [
`text-rose-500`,
`text-yellow-500`,
Expand Down Expand Up @@ -127,55 +121,25 @@ function Index() {
/>
</Link>
</ClientOnly>
<React.Suspense
fallback={
<div className="cursor-pointer relative z-10">
<NetlifyImage
src="/images/logos/splash-light.png"
width={500}
height={500}
quality={85}
className="w-[300px] pt-8 xl:pt-0 xl:w-[400px] 2xl:w-[500px] dark:hidden"
alt="TanStack Logo"
loading="eager"
fetchPriority="high"
/>
<NetlifyImage
src="/images/logos/splash-dark.png"
width={500}
height={500}
quality={85}
className="w-[300px] pt-8 xl:pt-0 xl:w-[400px] 2xl:w-[500px] hidden dark:block"
alt="TanStack Logo"
loading="eager"
fetchPriority="high"
/>
</div>
}
>
<LazyBrandContextMenu className="cursor-pointer relative z-10">
<NetlifyImage
src="/images/logos/splash-light.png"
width={500}
height={500}
quality={85}
className="w-[300px] pt-8 xl:pt-0 xl:w-[400px] 2xl:w-[500px] dark:hidden"
alt="TanStack Logo"
loading="eager"
fetchPriority="high"
/>
<NetlifyImage
src="/images/logos/splash-dark.png"
width={500}
height={500}
quality={85}
className="w-[300px] pt-8 xl:pt-0 xl:w-[400px] 2xl:w-[500px] hidden dark:block"
alt="TanStack Logo"
loading="eager"
fetchPriority="high"
/>
</LazyBrandContextMenu>
</React.Suspense>
<NetlifyImage
src="/images/logos/splash-light.png"
width={500}
height={500}
quality={85}
className="w-[300px] pt-8 xl:pt-0 xl:w-[400px] 2xl:w-[500px] dark:hidden"
alt="TanStack Logo"
loading="eager"
fetchPriority="high"
/>
<NetlifyImage
src="/images/logos/splash-dark.png"
width={500}
height={500}
quality={85}
className="w-[300px] pt-8 xl:pt-0 xl:w-[400px] 2xl:w-[500px] hidden dark:block"
alt="TanStack Logo"
loading="lazy"
/>
</div>
<div className="flex flex-col items-center gap-6 text-center px-4 xl:text-left xl:items-start">
<div className="flex gap-2 lg:gap-4 items-center">
Expand Down