Add secure field to ClickHouse connection config#5751
Open
meteoFurletov wants to merge 1 commit intoSQLMesh:mainfrom
Open
Add secure field to ClickHouse connection config#5751meteoFurletov wants to merge 1 commit intoSQLMesh:mainfrom
secure field to ClickHouse connection config#5751meteoFurletov wants to merge 1 commit intoSQLMesh:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secure: bool = Falsefield toClickhouseConnectionConfigfor explicitly enabling HTTPS/TLS"secure"to_connection_kwargs_keysso it gets passed through toclickhouse_connect.dbapi.connect()Problem
There is currently no way to explicitly enable HTTPS/TLS on a ClickHouse connection via SQLMesh config. Users must rely on port-based auto-detection (port 8443), which doesn't always work — especially when SQLMesh provides its own pool manager via
connection_pool_options.The
clickhouse-connectlibrary'sdbapi.connect()already accepts asecureparameter (bool) that controls HTTPS/TLS, butClickhouseConnectionConfigdoesn't expose it.Fix
Expose the
secureparameter thatclickhouse-connectalready supports:secure: bool = Falsefield aftertls_modein the HTTPS/TLS settings section"secure"to the_connection_kwargs_keysset so it's passed toconnect()Backwards compatibility
Fully backwards-compatible — defaults to
False, matching the current behavior.Test plan
_connection_kwargs_keyssecure: truein their config.yaml to enable HTTPS/TLS🤖 Generated with Claude Code