Precogs autofix e51871 078ac0

Lab_10/studentCourseEvaluation.cpp

@@ -4,181 +4,186 @@
 using namespace std;
 
 // creating a class named "Student"
-class Student
+void TakeData()
 {
-private:
-	string student_id;
-	string student_name;
-	double OOP2_Score;
-	double math_Score;
-	double english_Score;
-	double total_Score;
-	double ctotal()
-	{
-		total_Score = OOP2_Score + math_Score + english_Score;
-		return total_Score;
-	}
-
-public:
-	void TakeData()
-	{
-		cout << "ID : ";
-		cin >> student_id;
-		cout << "Name: ";
-		cin >> student_name;
-		cout << "OOP2: ";
-		cin >> OOP2_Score;
-		cout << "Math: ";
-		cin >> math_Score;
-		cout << "English: ";
-		cin >> english_Score;
-		ctotal();
-	}
-	void showData()
-	{
-
-		cout << "ID: " << student_id << endl;
-		cout << "Name: " << student_name << endl;
-		cout << "OOP2: " << OOP2_Score << endl;
-		cout << "Math: " << math_Score << endl;
-		cout << "English: " << english_Score << endl;
-		cout << "Total score: " << total_Score << endl;
-	}
-};
+    // PRECOGS_FIX: perform robust input validation and allow spaces in name using getline
+    #include <limits>
+
+    cout << "ID : ";
+    if (!(cin >> student_id)) {
+        cin.clear();
+        string tmp;
+        getline(cin, tmp);
+        cout << "Invalid ID input. Aborting input." << endl;
+        return;
+    }
+
+    // consume the trailing newline before using getline for full name
+    cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
+    cout << "Name: ";
+    if (!std::getline(cin, student_name) || student_name.empty()) {
+        cout << "Invalid name input. Aborting input." << endl;
+        return;
+    }
+
+    auto readValidatedDouble = [&](const string &prompt, double &out, double minVal = 0.0, double maxVal = 1000.0) {
+        while (true) {
+            cout << prompt;
+            if (cin >> out) {
+                if (out >= minVal && out <= maxVal) {
+                    break;
+                }
+                cout << "Value out of accepted range (" << minVal << " - " << maxVal << "). Try again." << endl;
+            } else {
+                // PRECOGS_FIX: clear stream and discard invalid token before retry
+                cin.clear();
+                string discard;
+                getline(cin, discard);
+                cout << "Invalid numeric input. Try again." << endl;
+            }
+        }
+    };
+
+    readValidatedDouble("OOP2: ", OOP2_Score, 0.0, 100.0);
+    readValidatedDouble("Math: ", math_Score, 0.0, 100.0);
+    readValidatedDouble("English: ", english_Score, 0.0, 100.0);
+
+    ctotal();
+}
 
 // creating a class named "Employee"
-class Employee
+double total_salary()
 {
-private:
-	string Employee_ID;
-	string Employee_Name;
-	int Hours;
-	int Rate;
-
-public:
-	void setEmployee_ID(string x)
-	{
-		Employee_ID = x;
-	}
-	string getEmployee_ID()
-	{
-		return Employee_ID;
-	}
-	void setEmployee_Name(string y)
-	{
-		Employee_Name = y;
-	}
-	string getEmployee_Name()
-	{
-		return Employee_Name;
-	}
-	void setHours(int z)
-	{
-		Hours = z;
-	}
-	int getHours()
-	{
-		return Hours;
-	}
-	void setRate(int i)
-	{
-		Rate = i;
-	}
-	int getRate()
-	{
-		return Rate;
-	}
-	double total_salary()
-	{
-		int total;
-		total = Hours * Rate;
-		return total;
-	}
-};
+    // PRECOGS_FIX: validate inputs and perform multiplication in 64-bit to avoid 32-bit overflow
+    #include <limits>
+
+    long long h = static_cast<long long>(Hours);
+    long long r = static_cast<long long>(Rate);
+
+    // Basic validation: no negative hours/rate allowed for salary computation
+    if (h < 0 || r < 0) {
+        return 0.0;
+    }
+
+    const long long maxAllowed = std::numeric_limits<long long>::max();
+    if (r != 0 && h > maxAllowed / r) {
+        // Overflow would occur. Cap at max representable or handle as error.
+        return static_cast<double>(maxAllowed);
+    }
+
+    long long total = h * r;
+    return static_cast<double>(total);
+}
 
 int main()
 {
-	int choice;
-	cout << "1. Student" << endl;
-	cout << "2. Employee" << endl;
-	cout << "Your choice: ";
-	cin >> choice;
-	cout << endl;
-
-	Student student;   // creating an object of a class "Student"
-	Employee employee; // creating an object of a class "Employee"
-	switch (choice)
-	{
-	case 1:
-	{
-		student.TakeData();
-		cout << endl;
-		student.showData();
-	}
-	break;
-	case 2:
-	{
-		while (true)
-		{
-			system("cls");
-			int choice_employee;
-
-			cout << "1. Input Employee Details\n";
-			cout << "2. Display Employee Details\n";
-			cout << "3. Display Salary\n";
-			cin >> choice_employee;
-			switch (choice_employee)
-			{
-			case 1:
-			{
-				string x, y;
-				int z, i;
-				system("cls");
-				cout << "\t\t\tEmployee information\n";
-				cout << "Employee_ID: ";
-				cin >> x;
-				cout << "Employee_Name: ";
-				cin >> y;
-				cout << "Number of worked Hours: ";
-				cin >> z;
-				cout << "Rate per Hour: ";
-				cin >> i;
-				cout << endl;
-				employee.setEmployee_ID(x);
-				employee.setEmployee_Name(y);
-				employee.setHours(z);
-				employee.setRate(i);
-				system("pause");
-			}
-			break;
-			case 2:
-			{
-				system("cls");
-				cout << "ID: " << employee.getEmployee_ID() << endl;
-				cout << "Name: " << employee.getEmployee_Name() << endl;
-				cout << "Hours: " << employee.getHours() << endl;
-				cout << "Rate: " << employee.getRate() << endl;
-				system("pause");
-			}
-			break;
-			case 3:
-			{
-				system("cls");
-				cout << "Total salary: " << employee.total_salary() << endl;
-				system("pause");
-			}
-			break;
-			default:
-				cout << "Incorrect input! Try again!" << endl;
-				break;
-			}
-		}
-	}
-	break;
-	default:
-		cout << "Incorrect input! Try again!" << endl;
-		break;
-	}
-	system("pause");
-	return 0;
+    // PRECOGS_FIX: remove unsafe system() use and replace with portable/controlled clear and pause behavior
+    #include <limits>
+
+    auto clearScreen = []() {
+        // Best-effort portable clear: print several newlines instead of calling system("cls")/system("clear")
+        for (int i = 0; i < 50; ++i) std::cout << '\n';
+    };
+
+    auto pausePrompt = []() {
+        std::cout << "Press Enter to continue..." << std::endl;
+        std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
+        std::cin.get();
+    };
+
+    int choice;
+    std::cout << "1. Student" << std::endl;
+    std::cout << "2. Employee" << std::endl;
+    std::cout << "Your choice: ";
+    if (!(std::cin >> choice)) {
+        std::cerr << "Invalid input. Exiting." << std::endl;
+        return 1;
+    }
+    std::cout << std::endl;
+
+    Student student;   // creating an object of a class "Student"
+    Employee employee; // creating an object of a class "Employee"
+    switch (choice)
+    {
+    case 1:
+    {
+        student.TakeData();
+        std::cout << std::endl;
+        student.showData();
+    }
+    break;
+    case 2:
+    {
+        while (true)
+        {
+            clearScreen(); // PRECOGS_FIX: avoid system("cls") to reduce execution of shell commands
+            int choice_employee;
+
+            std::cout << "1. Input Employee Details\n";
+            std::cout << "2. Display Employee Details\n";
+            std::cout << "3. Display Salary\n";
+            if (!(std::cin >> choice_employee)) {
+                std::cin.clear();
+                std::string discard;
+                std::getline(std::cin, discard);
+                std::cout << "Invalid selection. Try again." << std::endl;
+                pausePrompt(); // PRECOGS_FIX: replace system("pause") with controlled prompt
+                continue;
+            }
+            switch (choice_employee)
+            {
+            case 1:
+            {
+                std::string x, y;
+                int z, i;
+                clearScreen();
+                std::cout << "\t\t\tEmployee information\n";
+                std::cout << "Employee_ID: ";
+                if (!(std::cin >> x)) { std::cin.clear(); std::getline(std::cin, x); }
+                std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
+                std::cout << "Employee_Name: ";
+                std::getline(std::cin, y);
+                std::cout << "Number of worked Hours: ";
+                while (!(std::cin >> z)) { std::cin.clear(); std::string discard; std::getline(std::cin, discard); std::cout << "Invalid hours. Enter integer: "; }
+                std::cout << "Rate per Hour: ";
+                while (!(std::cin >> i)) { std::cin.clear(); std::string discard; std::getline(std::cin, discard); std::cout << "Invalid rate. Enter integer: "; }
+                std::cout << std::endl;
+                employee.setEmployee_ID(x);
+                employee.setEmployee_Name(y);
+                employee.setHours(z);
+                employee.setRate(i);
+                pausePrompt();
+            }
+            break;
+            case 2:
+            {
+                clearScreen();
+                std::cout << "ID: " << employee.getEmployee_ID() << std::endl;
+                std::cout << "Name: " << employee.getEmployee_Name() << std::endl;
+                std::cout << "Hours: " << employee.getHours() << std::endl;
+                std::cout << "Rate: " << employee.getRate() << std::endl;
+                pausePrompt();
+            }
+            break;
+            case 3:
+            {
+                clearScreen();
+                std::cout << "Total salary: " << employee.total_salary() << std::endl;
+                pausePrompt();
+            }
+            break;
+            default:
+                std::cout << "Incorrect input! Try again!" << std::endl;
+                pausePrompt();
+                break;
+            }
+        }
+    }
+    break;
+    default:
+        std::cout << "Incorrect input! Try again!" << std::endl;
+        break;
+    }
+    pausePrompt();
+    return 0;
 }