A11y Bug 10987393: [OneNote Clipper] [Web] [high contrast]: After applying High Contrast theme, selected state focus is not visible.#649
Merged
KethanaReddy7 merged 3 commits intouser/kpeddireddy/LocationButtonTabfrom Mar 26, 2026
Conversation
…d mode buttons In Windows high contrast themes (Aquatic, Desert), the selected state of font radio buttons (Sans Serif/Serif) and mode buttons (Article, etc.) was not visually distinguishable due to forced-colors overriding hardcoded CSS colors. Add explicit high contrast rules using CSS system color keywords (Highlight, HighlightText) to clearly indicate the selected/active state. Co-authored-by: KethanaReddy7 <257986085+KethanaReddy7@users.noreply.github.com> Agent-Logs-Url: https://github.com/OneNoteDev/WebClipper/sessions/fc60bfbc-74fc-43f1-a7a2-e376898f9ca1
Copilot
AI
changed the title
[WIP] Fix focus visibility in high contrast theme for OneNote Clipper
Fix selected state visibility for font radio buttons and mode buttons in high contrast themes
Mar 23, 2026
aanchalbhansali
changed the base branch from
master
to
user/kpeddireddy/LocationButtonTab
aanchalbhansali
changed the base branch from
user/kpeddireddy/LocationButtonTab
to
master
|
@claude remove styling for claude buttons that you added. |
|
Claude finished @KethanaReddy7's task in 41s —— View job Clarification Needed
I've reviewed the changes in this PR, but I don't see any "claude buttons" styling. This PR adds styling for:
Both are high contrast accessibility fixes to make selected states visible in Windows high contrast themes. Could you clarify which styling you'd like me to remove? If you'd like me to remove both button styles, that would undo the accessibility fix this PR is meant to provide. |
|
@claude remove styling for the mode buttons that you have added |
|
Claude finished @KethanaReddy7's task in 47s —— View job Removed Mode Button Styling
Done! I've removed the |
Co-authored-by: KethanaReddy7 <KethanaReddy7@users.noreply.github.com>
KethanaReddy7
changed the title
KethanaReddy7
changed the base branch from
master
to
user/kpeddireddy/LocationButtonTab
KethanaReddy7
merged commit d2b3aaa
into
user/kpeddireddy/LocationButtonTab
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Windows high contrast themes (Aquatic, Desert), the browser's
forced-colorsmode remaps hardcoded CSS colors to system colors, causing the selected state of font radio buttons (Sans Serif/Serif) and mode buttons (Article, Full Page, etc.) to be visually indistinguishable from their unselected states.Changes
src/styles/clipper.less— Added two rule blocks inside the existing@media (forced-colors: active)query:.control-button.active: explicitly setsHighlight/HighlightTextsystem colors so the selected font radio button is always visually distinctDemo:
https://github.com/user-attachments/assets/ea220f99-9067-4754-9c14-0269eb0d537d