Open
Conversation
Design for adding a persistent interactive terminal panel to Agent Session view using node-pty + xterm.js architecture.
Step-by-step plan for implementing terminal feature with node-pty + xterm.js across 10 tasks. Signed-off-by: GuanMu <ballmanjq@gmail.com>
…nels) Signed-off-by: GuanMu <ballmanjq@gmail.com>
Signed-off-by: GuanMu <ballmanjq@gmail.com>
Signed-off-by: GuanMu <ballmanjq@gmail.com>
Signed-off-by: GuanMu <ballmanjq@gmail.com>
Signed-off-by: GuanMu <ballmanjq@gmail.com>
Signed-off-by: GuanMu <ballmanjq@gmail.com>
Signed-off-by: GuanMu <ballmanjq@gmail.com>
Signed-off-by: GuanMu <ballmanjq@gmail.com>
Signed-off-by: GuanMu <ballmanjq@gmail.com>
Replace PanelGroup with Group, PanelResizeHandle with Separator, and adjust direction prop to orientation. Signed-off-by: GuanMu <ballmanjq@gmail.com>
Signed-off-by: GuanMu <ballmanjq@gmail.com>
…sion management - Removed outdated agent terminal design document. - Added TerminalService to manage PTY instances and session-specific working directories. - Enhanced SessionService to retrieve session details by ID. - Updated AgentChat component to manage terminal visibility and errors per session. - Refactored TerminalPanel to support dynamic theming and session management. - Implemented tests for TerminalService and AgentChat components to ensure functionality.
Collaborator
|
amazing work! Can you change the base to v2? We are about to freeze any PRs submitted to the main branch, switching to V2 will facilitate faster review and merge. |
Collaborator
|
https://www.npmjs.com/package/@lydell/node-pty only offer prebuilt packages for the current platform, consider switching to this one. |
Contributor
Author
|
@DeJeune |
Signed-off-by: GuanMu <ballmanjq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR introduces an Agent Terminal execution capability for Cherry Studio.
A Terminal panel is added to agent sessions (xterm.js + node-pty) so the agent can run shell commands and stream output back to the UI, enabling full “reasoning → execution → feedback” workflows.
Before this PR:
After this PR:
Fixes #13887
Why we need it and why it was done in this way
We need a way for agents to perform real operations in developer workflows (running scripts, starting servers, debugging, etc.).
A terminal is the most general execution interface (CLI-first, broad coverage). Using PTY provides high fidelity, cross-platform behavior.
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Breaking changes
None.
Special notes for your reviewer
Please pay attention to:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note