Skip to content

fix(MemoryService): handle missing embedding model in memory configuration#13823

Merged
kangfenmao merged 1 commit intoCherryHQ:v2from
alephpiece:v2-embeddingModel-not-set
Mar 31, 2026
Merged

fix(MemoryService): handle missing embedding model in memory configuration#13823
kangfenmao merged 1 commit intoCherryHQ:v2from
alephpiece:v2-embeddingModel-not-set

Conversation

@alephpiece
Copy link
Copy Markdown
Collaborator

What this PR does

Skips embeddingApiClient if the embedding model is not set. This could happen after switching from main to v2.

Before this PR:

image

After this PR:

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Breaking changes

If this PR introduces breaking changes, please describe the changes and the impact on users.

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note


@alephpiece alephpiece requested a review from a team March 26, 2026 09:45
@alephpiece alephpiece added the v2 label Mar 26, 2026
Copy link
Copy Markdown
Collaborator

@DeJeune DeJeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangfenmao kangfenmao merged commit 19c5db4 into CherryHQ:v2 Mar 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants