-
Notifications
You must be signed in to change notification settings - Fork 2k
update.sh fails to update with pruned variants #2438
Description
Environment
- Platform: Ubuntu 24.04.4 LTS
- Docker Version: N/A
- Node.js Version: 24.14.1
- Image Tag: N/A
Expected Behavior
To simulate dropping older variants in the upcoming Node.js 26, I removed all variants, except for trixie in a test branch for Node.js 25. (Not a real suggestion, just a setup for easier testing.)
I expected that running ./update.sh with no parameters would continue to update Node.js 25. In fact it skipped it.
Current Behavior
If the versions.json matrix contains a version key that does not include all variants, then that version is ignored and not updated at all.
Possible Solution
Modify ./update.sh to allow individual allocation of variants to versions.
Steps to Reproduce
Replace the 25 key in versions.json with a completely stripped down list of variants, with only trixie as a remaining entry. Delete also the corresponding sub-directories of 25 containing the Dockerfiles.
Execute:
./update.sh 25 trixieAdditional Information
Logs
$ ./update.sh 25 trixie
Updating version 20...
Updating version 22...
Updating version 24...
22/trixie/Dockerfile is already up to date!
24/trixie/Dockerfile is already up to date!
20/trixie/Dockerfile is already up to date!
Done!
This should update only 25, but instead updates everything except 25.